Bug 17362 - discovered dead code in SVG stylesheet title handling of "&"
Summary: discovered dead code in SVG stylesheet title handling of "&"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-14 10:32 PST by Darin Adler
Modified: 2012-05-19 17:06 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-02-14 10:32:44 PST
In Document::recalcStyleSelector I discovered some dead code that I removed:

#if ENABLE(SVG)
                // FIXME: What's the point of changing the value of a local variable
                // (title) that's not looked at afterward? Obviously there's no test
                // case for this!
                if (!n->isHTMLElement()) {
                    String modifiedTitle = title.domString();
                    title = modifiedTitle.replace('&', "&&");
                }
#endif

We should figure out what this code was trying to do, and then possibly re-add the code with a test case.
Comment 1 Nikolas Zimmermann 2012-05-19 17:06:35 PDT
In practice this never turned out to be a problem - closing this bug.