Bug 17325 - Remove PLATFORM ifdefs from HTMLFormElement
Summary: Remove PLATFORM ifdefs from HTMLFormElement
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-12 01:33 PST by Eric Seidel (no email)
Modified: 2022-07-25 17:46 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-02-12 01:33:48 PST 
Remove PLATFORM ifdefs from HTMLFormElement

html/HTMLFormElement.cpp:45:#if PLATFORM(QT)
html/HTMLFormElement.cpp:49:#if PLATFORM(WX)
html/HTMLFormElement.cpp:54:#if PLATFORM(WIN_OS)
html/HTMLFormElement.cpp:210:#if PLATFORM(DARWIN)
html/HTMLFormElement.cpp:230:#if PLATFORM(QT)
html/HTMLFormElement.cpp:232:#elif PLATFORM(WX)
html/HTMLFormElement.cpp:234:#elif PLATFORM(WIN_OS)

There is no reason why we need these there.  We need a random number platform abstraction and a way to do filename operations.  Both belong in platform/ not in HTMLFormElement.cpp
Comment 1 Ahmad Saleem 2022-07-25 16:40:49 PDT 
I can't find keyword "Platform" in Webkit Github repo as of today:

https://github.com/WebKit/WebKit/blob/c68178ddc01939b4bce3cdb9718c62087649dad4/Source/WebCore/html/HTMLFormElement.cpp

https://github.com/WebKit/WebKit/blob/e4e4bba1f291d4773b907199bb5e6976d14c223d/Source/WebCore/html/HTMLFormElement.h

I think this can be marked as "RESOLVED CONFIGURATION CHANGED". Thanks!