Bug 14391 - [html-parsing] make entity handling match IE7 / HTML5
Summary: [html-parsing] make entity handling match IE7 / HTML5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://simon.html5.org/test/html/pars...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-25 10:02 PDT by Simon Pieters
Modified: 2010-09-21 13:52 PDT (History)
9 users (show)

See Also:


Attachments
001: Entities in content (9.34 KB, text/html)
2007-06-25 10:04 PDT, Simon Pieters
no flags Details
002: Entities in attributes (9.54 KB, text/html)
2007-06-25 10:04 PDT, Simon Pieters
no flags Details
003: Entities in attributes (9.36 KB, text/html)
2007-06-25 10:04 PDT, Simon Pieters
no flags Details
005: EOF while parsing an entity (103 bytes, text/html)
2007-06-25 10:05 PDT, Simon Pieters
no flags Details
tests in a diff (31.77 KB, patch)
2010-09-20 01:04 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (32.74 KB, patch)
2010-09-20 01:21 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (33.99 KB, patch)
2010-09-20 18:48 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pieters 2007-06-25 10:02:10 PDT
Semi-colonless entities in content aren't supported (001). ™ is not supported (001..003). If EOF is hit while parsing an entity, it is dropped altogether (005). (004 passes.)

Relevant spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/section-tokenisation.html#tokenising
Comment 1 Simon Pieters 2007-06-25 10:04:00 PDT
Created attachment 15226 [details]
001: Entities in content
Comment 2 Simon Pieters 2007-06-25 10:04:17 PDT
Created attachment 15227 [details]
002: Entities in attributes
Comment 3 Simon Pieters 2007-06-25 10:04:41 PDT
Created attachment 15228 [details]
003: Entities in attributes
Comment 4 Simon Pieters 2007-06-25 10:05:15 PDT
Created attachment 15229 [details]
005: EOF while parsing an entity
Comment 5 Alexey Proskuryakov 2007-07-02 06:01:55 PDT
Confirmed.
Comment 6 Adam Barth 2010-08-20 10:45:22 PDT
This most likely fixed now, but should be turned into some tests.
Comment 7 Adam Barth 2010-09-20 01:04:09 PDT
Looks like we might have a problem with the AElig entity.  It's the first one on the list, so it could be a problem with the entity search.
Comment 8 Adam Barth 2010-09-20 01:04:41 PDT
Created attachment 68057 [details]
tests in a diff
Comment 9 Adam Barth 2010-09-20 01:21:44 PDT
Created attachment 68058 [details]
Patch
Comment 10 Adam Barth 2010-09-20 18:48:48 PDT
Created attachment 68174 [details]
Patch
Comment 11 WebKit Commit Bot 2010-09-21 12:37:28 PDT
Comment on attachment 68174 [details]
Patch

Clearing flags on attachment: 68174

Committed r67975: <http://trac.webkit.org/changeset/67975>
Comment 12 WebKit Commit Bot 2010-09-21 12:37:34 PDT
All reviewed patches have been landed.  Closing bug.