Bug 13673 - m_lastChangeWasHorizontalExtension not always cleared when it should be
Summary: m_lastChangeWasHorizontalExtension not always cleared when it should be
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-10 22:53 PDT by Justin Garcia
Modified: 2022-12-19 14:25 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2007-05-10 22:53:08 PDT 
See editing/selection/5195166-1.html
This boolean needs to be cleared when opening a new document, when programatically changing the selection.  Also programattic modify()s should probably be treated as userTriggered selection operations, since they exist primarily to test user triggered operations.
Comment 1 Ahmad Saleem 2022-12-18 05:47:13 PST 
Justin added this FIXME via this commit:

https://github.com/WebKit/WebKit/commit/94dbb6b9a2e1b1803adc4fbd7c5ff7c787e78920

but now in the latest test case does not have this:

https://github.com/WebKit/WebKit/blob/11adcf008ef8a0287a435298802c45749dd17cc1/LayoutTests/editing/selection/5195166-1.html#L4

Do we need to do anything more here? Thanks!
Comment 2 Ryosuke Niwa 2022-12-19 14:25:19 PST 
Yeah, https://commits.webkit.org/47861@main removed this code.