Bug 13531 - copyright sign in Latin1 leads to a warning
Summary: copyright sign in Latin1 leads to a warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Windows XP
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-27 20:49 PDT by Jungshik Shin
Modified: 2007-04-29 00:03 PDT (History)
0 users

See Also:


Attachments
patch (893 bytes, patch)
2007-04-27 20:59 PDT, Jungshik Shin
sam: review-
Details | Formatted Diff | Diff
patch with changelog fix (1015 bytes, patch)
2007-04-28 11:37 PDT, Jungshik Shin
no flags Details | Formatted Diff | Diff
patch with changelog fixed (1014 bytes, patch)
2007-04-28 11:38 PDT, Jungshik Shin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jungshik Shin 2007-04-27 20:49:34 PDT
npruntime.h has a copyright sign in Latin-1 encoding (0xA9). It should be replaced by '(C)'.
Comment 1 Jungshik Shin 2007-04-27 20:59:51 PDT
Created attachment 14238 [details]
patch

one liner
Comment 2 Sam Weinig 2007-04-28 09:13:43 PDT
Comment on attachment 14238 [details]
patch

Patch looks good to me.  The changelog, however, needs to be cleaned up a little to include your name and email address where jungshik  <set EMAIL_ADDRESS environment variable> currently is and to add the bugzilla url as well.  Thanks for the patch.
r- for now.
Comment 3 Jungshik Shin 2007-04-28 11:37:02 PDT
Created attachment 14244 [details]
patch with changelog fix
Comment 4 Jungshik Shin 2007-04-28 11:38:34 PDT
Created attachment 14245 [details]
patch with changelog fixed
Comment 5 Sam Weinig 2007-04-28 14:01:11 PDT
Comment on attachment 14245 [details]
patch with changelog fixed

r=me
Comment 6 Jungshik Shin 2007-04-28 14:42:56 PDT
thanks. can you land it as well? 
Comment 7 Mark Rowe (bdash) 2007-04-29 00:03:33 PDT
Landed in r21178.