Bug 12970 - Fix and import 4XPath test_core_functions.html test
Summary: Fix and import 4XPath test_core_functions.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 12953
  Show dependency tree / graph
 
Reported: 2007-03-05 11:27 PST by Alexey Proskuryakov
Modified: 2007-03-05 12:53 PST (History)
0 users

See Also:

Attachments
proposed fix (17.65 KB, patch)
2007-03-05 11:36 PST, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-03-05 11:27:08 PST 
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2007-03-05 11:36:42 PST 
Created attachment 13479 [details]
proposed fix
Comment 2 Darin Adler 2007-03-05 12:13:40 PST 
Comment on attachment 13479 [details]
proposed fix

r=me

That round function looks kinda elaborate, maybe it can be done simpler later.
Comment 3 Alexey Proskuryakov 2007-03-05 12:53:06 PST 
Committed revision 19968.

(In reply to comment #2)
> That round function looks kinda elaborate, maybe it can be done simpler later.

It's a direct translation of the wording in the spec, but I couldn't find a better way to implement it. I also looked into Mozilla sources for inspiration.