SVG hits an assertion when svg container has x/y offset

[Oliver Hunt]

The linked xml file contains an svg that at some point seems to get x,y offsets applied to an svg container that is not the root element

[Eric Seidel (no email)]

Ok, we should just remove those asserts.

It turns out the when the root <svg> is translated in html (in a flow for example), it will pass this translation along to it's kids through the tx, ty calls, due to this implementation of RenderBox:

void RenderBox::paint(PaintInfo& paintInfo, int tx, int ty)
{
    tx += m_x;
    ty += m_y;

    // default implementation. Just pass paint through to the children
    PaintInfo childInfo(paintInfo);
    childInfo.paintingRoot = paintingRootForChildren(paintInfo);
    for (RenderObject* child = firstChild(); child; child = child->nextSibling())
        child->paint(childInfo, tx, ty);
}

We could also just use our own kid-painting code.

[Eric Seidel (no email)]

Created attachment 12546 [details]
remove asserts

replace the broken asserts with more helpful comments