Bug 12031 - Update embedded JavaScriptCore/pcre library from 6.1 to 6.2
Summary: Update embedded JavaScriptCore/pcre library from 6.1 to 6.2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.pcre.org/
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-29 18:37 PST by David Kilzer (:ddkilzer)
Modified: 2006-12-29 19:19 PST (History)
2 users (show)

See Also:

Attachments
Full pcre-6.1 to 6.2 diff (61.92 KB, patch)
2006-12-29 18:47 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v1 (5.38 KB, patch)
2006-12-29 18:48 PST, David Kilzer (:ddkilzer) 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-12-29 18:37:37 PST 
The current embedded JavaScriptCore/pcre library is version 6.1 (r10495) with some fixes from version 6.2 included in r14736.

I'm wondering if I should continue this work?  Various enhancements and bug fixes have been included in versions 6.3-6.7 and 7.0.
Comment 1 David Kilzer (:ddkilzer) 2006-12-29 18:47:11 PST 
Created attachment 12114 [details]
Full pcre-6.1 to 6.2 diff

Full diff between pcre-6.1 and 6.2 for reference.
Comment 2 David Kilzer (:ddkilzer) 2006-12-29 18:48:01 PST 
Created attachment 12115 [details]
Patch v1

Brings JavaScriptCore/pcre up to version 6.2.
Comment 3 Geoffrey Garen 2006-12-29 18:58:55 PST 
Comment on attachment 12115 [details]
Patch v1

r=me (assuming the layout tests and javascriptcore tests pass).

It would be nice to keep in step with PCRE, and upgrade to 7.x. The only reason we don't keep in lockstep is that it can be a lot of work to port PCRE to use UTF16 strings.
Comment 4 David Kilzer (:ddkilzer) 2006-12-29 19:19:53 PST 
(In reply to comment #3)
> (From update of attachment 12115 [details] [edit])
> r=me (assuming the layout tests and javascriptcore tests pass).

No regressions in layout tests or javascriptcore tests.  Committed revision 18483.