Bug 12025 - WebArchive fails to save background images in <tr> tags
Summary: WebArchive fails to save background images in <tr> tags
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-28 21:08 PST by David Kilzer (:ddkilzer)
Modified: 2015-08-04 09:41 PDT (History)
2 users (show)

See Also:

Attachments
WebArchive layout test (as patch) (4.97 KB, patch)
2006-12-28 21:11 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-12-28 21:08:00 PST 
When a .webarchive file is saved, any background images in <tr> tags are not serialized to the output file.
Comment 1 David Kilzer (:ddkilzer) 2006-12-28 21:11:01 PST 
Created attachment 12098 [details]
WebArchive layout test (as patch)

WebArchive layout test formatted as a patch.
Comment 2 Brady Eidson 2008-04-02 23:17:04 PDT 
This one is going to be very easy to fix with the new archive setup in WebCore
However, I have a question...  I find no evidence that <tr>s can officially have background images, standards-wise.  Therefore, I'm guessing this is some Mozilla or IE compatibility thing we added.

Looking at the HTMLTablePart code, it appears *any* table part can have a background image.  Is that correct? 

If so, shouldn't this patch make sure all table parts get their background images saved?
Comment 3 David Kilzer (:ddkilzer) 2008-04-03 13:25:55 PDT 
(In reply to comment #2)
> This one is going to be very easy to fix with the new archive setup in WebCore
> However, I have a question...  I find no evidence that <tr>s can officially
> have background images, standards-wise.  Therefore, I'm guessing this is some
> Mozilla or IE compatibility thing we added.
> 
> Looking at the HTMLTablePart code, it appears *any* table part can have a
> background image.  Is that correct? 
> 
> If so, shouldn't this patch make sure all table parts get their background
> images saved?

At the time, I think I only tested <tr> tags.  If HTMLTablePart supports background images on all parts, then we should archive them.
Comment 4 Brady Eidson 2008-04-03 15:00:44 PDT 
A few further points of discussion:
-The background attribute isn't officially supported for anything but <body>, I think, so its weird and nonstandard that we support it for any table parts
-The background attribute for HTMLTablePart is fed directly into inline style information and handled in a very CSSey fashion.
-Therefore, while we could support archiving the resource pointed to by the background attribute for table parts specifically, there's a broader-reaching problem of archiving resources referred to by all inline style.

Not saying I don't plan to fix this specific bug, but... the more accurate we get with esoteric subresources (like background images of <tr>s), the more apparent it is that we're ignoring a large class of subresources
Comment 5 Brian Burg 2014-12-14 19:59:28 PST 
WAR export isn't supported these days.
Comment 6 Brian Burg 2014-12-14 20:01:11 PST 
Oops, thought this was filed as an inspector bug.