Bug 12009 - Missing script comment close causes incomplete rendering of www.venganza.org
Summary: Missing script comment close causes incomplete rendering of www.venganza.org
Status: RESOLVED DUPLICATE of bug 16722
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.venganza.org
Keywords: HasReduction
: 17412 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-12-27 18:27 PST by J. Grybowski
Modified: 2008-02-18 00:51 PST (History)
5 users (show)

See Also:


Attachments
Testcase (258 bytes, text/html)
2007-01-27 10:48 PST, Matt Lilek
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description J. Grybowski 2006-12-27 18:27:23 PST
The home page of the parody religion, Church of the Flying Spaghetti Monster, has serious issues with Webkit: almost all content below the main navigation refuses to display. Page displays with no problems in Safari.

Not being that well-versed in coding and all that, I'm not exactly sure what's wrong, but if I had to venture a guess, I'd say it probably had something to do with handling of imported CSS or Javascript. Again, just a guess: I'll leave it up to the people who know this stuff to actually figure it out.
Comment 1 J. Grybowski 2006-12-27 18:29:07 PST
(In reply to comment #0)
> The home page of the parody religion, Church of the Flying Spaghetti Monster,
> has serious issues with Webkit: almost all content below the main navigation
> refuses to display. Page displays with no problems in Safari.

That last bit, of course, should be "Page displays with no problems in Firefox."
Comment 2 jonathanjohnsson 2006-12-30 03:59:27 PST
WebKit r18481 shows the pages on that site fine for me, with the exception of the home page, where something is broke.
Comment 3 Matt Lilek 2006-12-30 12:23:25 PST
I looked at this the other night and I'm wondering if this is really a bug in WebKit or not.

There is less content when viewed in Safari/WebKit than Firefox because of an inline script that doesn't close the comment it opens with.  Firefox/IE7 seem to ignore this and assume the comment ends at the end of the script and continues on and continues to render the page.  Shipping Safari, ToT and Opera ignore the rest of the page.  Remove the poorly coded script and everybody renders fine.

#primary contains all of the posts and is floated left.  Since we think that everything after that is commented out, we never render the div to clear it so .content collapses up like it should and results in the rendering we see.
Comment 4 Darin Adler 2007-01-22 09:56:25 PST
(In reply to comment #3)
> There is less content when viewed in Safari/WebKit than Firefox because of an
> inline script that doesn't close the comment it opens with.  Firefox/IE7 seem
> to ignore this and assume the comment ends at the end of the script and
> continues on and continues to render the page.  Shipping Safari, ToT and Opera
> ignore the rest of the page.  Remove the poorly coded script and everybody
> renders fine.

Lets make a test case for this, then. I'd think we should match the browsers that have more market share than us on this if possible -- should help compatibility.
Comment 5 Matt Lilek 2007-01-22 10:21:04 PST
(In reply to comment #4)
> 
> Lets make a test case for this, then. I'd think we should match the browsers
> that have more market share than us on this if possible -- should help
> compatibility.
> 

Unfortunately, they seem to have corrected the bug on their end and I no longer have the copy I saved locally to figure this out and I can't seem to find a cached copy anywhere.
Comment 6 David Kilzer (:ddkilzer) 2007-01-22 11:20:47 PST
(In reply to comment #5)
> Unfortunately, they seem to have corrected the bug on their end and I no longer
> have the copy I saved locally to figure this out and I can't seem to find a
> cached copy anywhere.

Can you grab a copy of their home page (use Firefox to save as "Web Page, Complete") and then start removing "// -->" lines in the code until the issue is duplicated?

Comment 7 Matt Lilek 2007-01-22 12:11:21 PST
(In reply to comment #6)
> Can you grab a copy of their home page (use Firefox to save as "Web Page,
> Complete") and then start removing "// -->" lines in the code until the issue
> is duplicated?

I'm gonna try that tonight.
Comment 8 Matt Lilek 2007-01-27 10:48:26 PST
Created attachment 12713 [details]
Testcase

I managed to find a local copy of this after all (hooray being unorganized?).  Here's a reduction.

There should be two divs visible - a green one and a red one.  WebKit only displays the green one up to where the script starts.
Comment 9 Robert Blaut 2008-02-18 00:42:04 PST
*** Bug 17412 has been marked as a duplicate of this bug. ***
Comment 10 Robert Blaut 2008-02-18 00:51:31 PST

*** This bug has been marked as a duplicate of 16722 ***