Quicktime plugin getting returned for flash content

[Steve Gehrman]

WebPluginDatabase.m 

WebKit randomly returns Quicktime plugin for flash content (could effect any plugin, but flash for sure)

Depending on which order the plugins are found, Quicktime can be returned instead of Flash Player.

See the // ## lines below for the additions I added.  The problem is if Quicktime is found first, flash isn't used.

- (WebBasePluginPackage *)pluginForKey:(NSString *)key withEnumeratorSelector:(SEL)enumeratorSelector
{
    WebBasePluginPackage *plugin, *CFMPlugin=nil, *machoPlugin=nil, *webPlugin=nil;
    NSEnumerator *pluginEnumerator = [plugins objectEnumerator];
    key = [key lowercaseString];

    while ((plugin = [pluginEnumerator nextObject]) != nil) {
        if ([[[plugin performSelector:enumeratorSelector] allObjects] containsObject:key]) {
            if ([plugin isKindOfClass:[WebPluginPackage class]]) {
                
                // ### added the || [webPlugin isQuickTimePlugIn]
                if (!webPlugin || [webPlugin isQuickTimePlugIn])
                    webPlugin = plugin;
                
            } else if([plugin isKindOfClass:[WebNetscapePluginPackage class]]) {
                WebExecutableType executableType = [(WebNetscapePluginPackage *)plugin executableType];
                if (executableType == WebCFMExecutableType) {
                    
                    // ### added the || [CFMPlugin isQuickTimePlugIn]
                    if (!CFMPlugin || [CFMPlugin isQuickTimePlugIn])
                        CFMPlugin = plugin;
                    
                } else if (executableType == WebMachOExecutableType) {
                    
                    // ### added the || [machoPlugin isQuickTimePlugIn]
                    if (!machoPlugin || [machoPlugin isQuickTimePlugIn])
                        machoPlugin = plugin;
                    
                } else {
                    ASSERT_NOT_REACHED();
                }
            } else {
                ASSERT_NOT_REACHED();
            }
        }
    }
        
    // Allow other plug-ins to win over QT because if the user has installed a plug-in that can handle a type
    // that the QT plug-in can handle, they probably intended to override QT.
    if (webPlugin && ![webPlugin isQuickTimePlugIn])
        return webPlugin;
    else if (machoPlugin && ![machoPlugin isQuickTimePlugIn])
        return machoPlugin;
    else if (CFMPlugin && ![CFMPlugin isQuickTimePlugIn])
        return CFMPlugin;
    else if (webPlugin)
        return webPlugin;
    else if (machoPlugin)
        return machoPlugin;
    else if (CFMPlugin)
        return CFMPlugin;
    return nil;
}

[Mark Rowe (bdash)]

Steve, please see http://webkit.org/coding/contributing.html for information about how to contribute fixes to the code.  Pasting code into the description of a bug is not likely to get it committed to the tree.

[Steve Gehrman]

I guess this is why WebKit is so buggy.  And you wonder why people don't want to submit bugs?  It would take someone less than 30 seconds to update the code.  I didn't read that link and don't plan on reading it :)

[Mark Rowe (bdash)]

Thanks for your continued support Steve.

[Mark Rowe (bdash)]

CCing Tim Omernick as he appears to be the plugin guru.

[Derk-Jan Hartman]

As having worked on the VLC plugin, personally I think it would be better if there was configurability of the prioritizing of plugins. If you have 5 plugins handling the same stuff, you have absolutely no idea which plugin is gonna handle your material unless forced by the HTML. Being able to configure this (albeit trough a preference file without a GUI), would be very helpful.

P.S. We have seen similar behaviour in VLC plugin development, with an apparent bias for plugins with a more recent modification time.

[Ahmad Saleem]

I think something along these lines was implemented as in following:

**Webkit Legacy - WebPluginDatabase.m**

https://github.com/WebKit/WebKit/blob/429b498267a320854edc566001dde39c2f5af0d0/Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm#L117

I was not able to find "Webkit" source.

I think since it was implemented with approach of "Best candidtate" in Webkit Legacy and now removed from Webkit2 etc., I think this can be marked as "RESOLVED WORKSFORME" or "RESOLVED INVALID" etc.

Just wanted to update. Thanks!