Bug 11283 - Windows build was busted by change 4195
Summary: Windows build was busted by change 4195
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Brett Wilson (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-13 11:18 PDT by Brett Wilson (Google)
Modified: 2006-10-13 12:51 PDT (History)
0 users

See Also:


Attachments
Patch (1.43 KB, patch)
2006-10-13 11:19 PDT, Brett Wilson (Google)
kmccullough: review-
Details | Formatted Diff | Diff
Addresses comments (2.31 KB, patch)
2006-10-13 11:43 PDT, Brett Wilson (Google)
kmccullough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2006-10-13 11:18:54 PDT
http://build.webkit.org/changes/4195
Comment 1 Brett Wilson (Google) 2006-10-13 11:19:46 PDT
Created attachment 11071 [details]
Patch

Fixes window build bustage.
Comment 2 Kevin McCullough 2006-10-13 11:36:32 PDT
Comment on attachment 11071 [details]
Patch

Please remove the :: specifiers and change <DateMath.h> to "DateMath.h" for me.  Thanks
Comment 3 Brett Wilson (Google) 2006-10-13 11:43:16 PDT
Created attachment 11072 [details]
Addresses comments
Comment 4 Kevin McCullough 2006-10-13 11:46:03 PDT
Comment on attachment 11072 [details]
Addresses comments

looks good
Comment 5 Brett Wilson (Google) 2006-10-13 12:51:05 PDT
Fixed in r17037