Bug 109453 - Web Inspector: provide basic console.table implementation (no [,columns] support)
Summary: Web Inspector: provide basic console.table implementation (no [,columns] supp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 09:17 PST by Pavel Feldman
Modified: 2013-02-18 02:53 PST (History)
16 users (show)

See Also:


Attachments
[IMAGE] Screenshot with patch applied (20.64 KB, image/png)
2013-02-11 09:21 PST, Pavel Feldman
no flags Details
Patch (32.93 KB, patch)
2013-02-11 10:16 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (34.20 KB, patch)
2013-02-12 06:08 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[IMAGE] Screenshot with beverloo applied (20.55 KB, image/png)
2013-02-12 06:09 PST, Pavel Feldman
no flags Details
[wip] (46.59 KB, patch)
2013-02-17 02:56 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (45.49 KB, patch)
2013-02-17 04:38 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-02-11 09:17:40 PST
This change adds support for console.table command supported in Firebug. Here is the syntax:

    console.table([[1,2,3], [2,3,4]]);
    console.table([{a:1, b:2, c:3}, {a:"foo", b:false, c:undefined}]);

Screenshot to follow.
Comment 1 Pavel Feldman 2013-02-11 09:21:54 PST
Created attachment 187597 [details]
[IMAGE] Screenshot with patch applied
Comment 2 Pavel Feldman 2013-02-11 10:16:14 PST
Created attachment 187611 [details]
Patch
Comment 3 Andrey Adaikin 2013-02-11 10:50:59 PST
Comment on attachment 187611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187611&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:86
> +            delete this._dataGrid;

this._dataGrid was never defined
Comment 4 Pavel Feldman 2013-02-12 06:08:15 PST
Created attachment 187850 [details]
Patch
Comment 5 Pavel Feldman 2013-02-12 06:09:04 PST
Created attachment 187851 [details]
[IMAGE] Screenshot with beverloo applied
Comment 6 Pavel Feldman 2013-02-17 02:56:19 PST
Created attachment 188762 [details]
[wip]
Comment 7 Pavel Feldman 2013-02-17 04:38:02 PST
Created attachment 188763 [details]
Patch
Comment 8 Vsevolod Vlasov 2013-02-18 02:25:19 PST
Comment on attachment 188763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188763&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:151
> +        if (InjectedScriptHost.type(columns) == "array") {

===
Comment 9 WebKit Review Bot 2013-02-18 02:53:19 PST
Comment on attachment 188763 [details]
Patch

Clearing flags on attachment: 188763

Committed r143186: <http://trac.webkit.org/changeset/143186>
Comment 10 WebKit Review Bot 2013-02-18 02:53:23 PST
All reviewed patches have been landed.  Closing bug.