Bug 10203 - REGRESSION(r12587): amtrak.com home page continuously reloads
Summary: REGRESSION(r12587): amtrak.com home page continuously reloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Brady Eidson
URL: http://www.amtrak.com/
Keywords: InRadar, NeedsReduction, Regression
Depends on:
Blocks:
 
Reported: 2006-08-02 03:31 PDT by David Kilzer (:ddkilzer)
Modified: 2008-02-10 22:46 PST (History)
2 users (show)

See Also:


Attachments
Theorized to be the offending javascript (2.14 KB, text/plain)
2006-11-18 00:36 PST, Brady Eidson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-08-02 03:31:26 PDT
Steps to reproduce:

1. Open URL: http://www.amtrak.com/

Expected results:

Amtrak home page should load once.

Actual results:

Amtrak home page continuously reloads itself until the user hits Escape or Cmd-period.

Regression:

This does not occur in production Safari 2.0.4 (419.3) on Mac OS X 10.4.7 (8J135/PowerPC), or in Firefox 1.5.0.5.

Notes:

Tested on locally-built debug build of WebKit r15751.

Originally noted in Bug 10136 Comment #6.
Comment 1 David Kilzer (:ddkilzer) 2006-08-02 05:00:43 PDT
This may or may not be related, but there is a declared variable that is mispelled in this URL:  http://www.amtrak.com/servlet/ContentServer?pagename=Amtrak/HomePage

<script language="JavaScript1.2">
<!--
    var boolComplaint = false;
    try{boolCompliant = isCompliantBrowser();}catch(e){};    
...
</script>

The "var boolComplaint = false;" variable should be spelled "boolCompliant".
Comment 2 David Kilzer (:ddkilzer) 2006-08-03 04:08:02 PDT
This reloading also occurs on the Contact Us page:

http://www.amtrak.com/servlet/ContentServer?pagename=Amtrak/ContactUs
Comment 3 jonathanjohnsson 2006-08-03 14:34:20 PDT
I would say the bug is in the javascript sniffing of the page, as spoofing as any of the Gecko-based engines (in the debug menu) the page seems to load as it should.
Comment 4 Darin Adler 2006-08-03 21:41:59 PDT
I think it's correctly sniffing that this is Safari, but then I suspect they have something to work around a Safari bug that's no longer present.
Comment 5 Stephanie Lewis 2006-11-06 19:47:00 PST
radar 4709762
Comment 6 Brady Eidson 2006-11-09 00:34:46 PST
Using binary search and the nightly archives, tracked this one down to either 13059 or 13060
Comment 8 Brady Eidson 2006-11-09 00:37:25 PST
http://trac.webkit.org/projects/webkit/changeset/13060 was a DumpRenderTree only change - definitely must be 13059
Comment 9 Brady Eidson 2006-11-09 10:49:57 PST
Searching the nightlys was flawed - I was running on Intel hardware, under Rosetta, and apparently this made a different - 13058 on intel worked, 13058 on PPC does NOT work.

That curiosity aside, I tried on PPC hardware just now, and narrowed it to between 12563 and 12574
Comment 10 Brady Eidson 2006-11-09 11:46:55 PST
Confirming with locally built sources, this is due to 12571.

http://trac.webkit.org/projects/webkit/changeset/12571
Comment 11 Brady Eidson 2006-11-09 13:58:34 PST
12571 was rolled out and back in slightly modified in 12587

http://trac.webkit.org/projects/webkit/changeset/12587

Comment 12 Brady Eidson 2006-11-18 00:36:47 PST
Created attachment 11561 [details]
Theorized to be the offending javascript

This is pulled from www.amtrak.com/lib.js and seems to be the offending function.  Spoofing causes the bug to go away.  This function is the onload handler for an iFrame of theirs.

I'm going through the rest of the .js to see if there's anything else that goes Safari specific
Comment 13 Kevin McCullough 2007-02-01 11:30:45 PST
rdar://problem/4709762
Comment 14 David Kilzer (:ddkilzer) 2007-02-07 03:21:23 PST
Submitted feedback via the "Contact Us" page on amtrak.com about this bug.

http://www.amtrak.com/servlet/ContentServer?pagename=Amtrak/ContactUs

I got a positive response previously from the issue in Comment #1.

Comment 15 Maciej Stachowiak 2007-02-07 04:43:47 PST
Downgrading to P2 since this is an evangelism issue.
Comment 16 David Kilzer (:ddkilzer) 2007-02-07 06:27:38 PST
This may be helpful in fixing the bug:

http://trac.webkit.org/projects/webkit/wiki/DetectingWebKit

http://trac.webkit.org/projects/webkit/wiki/WebDevelopers

Comment 17 David Kilzer (:ddkilzer) 2007-02-07 06:30:43 PST
Response from customer service at amtrak.com:

From:   service@lob.amtrak.com
Subject: RE: Web Site Feedback
Date: February 7, 2007 6:52:47 AM CST
To:   ddkilzer@webkit.org

Dear David Kilzer, 

Thank you for contacting us. 

We appreciate your comments and suggestions regarding our website. 

Our web development staff evaluates the comments, opinions and suggestions of our customers visiting the site and this feedback is taken into consideration for future updates. 

Thank you again for taking the time to write to us. We look forward to serving you aboard Amtrak. 


Sincerely, Kathleen 
Customer Service 

 




-----Original Message----- 


From: ddkilzer@webkit.org 
Sent: 07 Feb 07 06:12:42 
To: 
Cc: 
Subject: Web Site Feedback 

Name: David Kilzer 
Email: ddkilzer@webkit.org 
Address1: 
Address2: 
City: 
State: 
Zip/Postal: 
Country: United States 
Phone Number: 
Subject: Web Site Feedback 


Message: 

Certain pages on the amtrak.com web site will continuously reload when viewed using a development release of Apple's web browser engine, called "WebKit", that is used by their web browser, Safari. It is important to fix this bug as an updated version of WebKit will be used with the next version of Mac OS X 10.5 ("Leopard"). 

Technical details of this issue may be found here: 

http://bugs.webkit.org/show_bug.cgi?id=10203 

If you have a Mac running Mac OS X 10.4.x ("Tiger"), you may download a nightly build of WebKit that you may use to test with the amtrak.com web site: 

http://nightly.webkit.org/ 

There is no need to install any software; simply download the DMG, mount it, and double-click on the gold Safari icon (which starts Safari with the updated WebKit engine). 

If you have any questions, please post them to the Bugzilla bug, or stop by the IRC channel mentioned on this page to get some live feedback/help/information. 

http://webkit.org/contact.html 

Thanks! 

Dave

Comment 18 Robert Blaut 2008-02-10 22:46:12 PST
I tested the site with Webkit r30123 and I didn't notice any buggy behavior. The bug is FIXED.