Bug 9085

Summary: Absolutely positioned objects with 'height': auto and 'top': and 'bottom': non-auto should not be content based
Product: WebKit Reporter: Sam Weinig <sam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkitbugz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
test case
none
patch
none
patch2
hyatt: review+
another test case of interest none

Description Sam Weinig 2006-05-23 18:02:05 PDT
Absolutly positioned objects that have a value other than auto for 'top' and 'bottom' and a value of auto for 'height' should not compute the height to be based on the content (like is done if either or both of 'top' and 'bottom' are auto).  Instead the value should be calculated using the constraint equation for absolutely position objects.
Comment 1 Sam Weinig 2006-05-23 18:02:56 PDT
Created attachment 8506 [details]
test case
Comment 2 Sam Weinig 2006-05-23 18:26:19 PDT
Created attachment 8507 [details]
patch

Moves overflow code to after all the height calculations have been made for calcAbsoluteVertical and entirely removes it from the replaced version where it should never be used.  Also moves the calculation of containerheight and containerwidth to sepertate functions inorder to share the code.
Comment 3 Sam Weinig 2006-05-24 18:14:54 PDT
Created attachment 8530 [details]
patch2

More targeted version of the patch.
Comment 4 Maciej Stachowiak 2006-05-27 01:05:09 PDT
Created attachment 8569 [details]
another test case of interest

Hyatt mentioned that the bug in this additional test case is likely to be related. In this case, percentage height for a child of an absolute positioned element with height unspecified but top and bottom specified is not handled correctly.
Comment 5 Sam Weinig 2006-05-27 16:03:21 PDT
Added bug 9137 to track the issue in maciej's test case.
Comment 6 Dave Hyatt 2006-05-29 23:11:09 PDT
Comment on attachment 8530 [details]
patch2

r=me
Comment 7 Beth Dakin 2006-05-30 13:44:20 PDT
I committed this patch.
Comment 8 David Kilzer (:ddkilzer) 2006-07-01 08:58:47 PDT
*** Bug 7174 has been marked as a duplicate of this bug. ***