Bug 82556

Summary: Remove ScriptExecutionContext from NavigatorBattery.idl
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2012-03-28 18:04:13 PDT
As Bug 73528 comment #71, NavigatorBattery.idl doesn't need to have ScriptExecutionContext. Document can be used instead of ScriptExecutionContext.
Comment 1 Gyuyoung Kim 2012-03-28 18:05:48 PDT
Created attachment 134456 [details]
Patch
Comment 2 Adam Barth 2012-03-28 18:11:30 PDT
Comment on attachment 134456 [details]
Patch

One argument constructors should have the "explicit" keyword.
Comment 3 Gyuyoung Kim 2012-03-28 18:52:20 PDT
Created attachment 134470 [details]
Patch
Comment 4 Gyuyoung Kim 2012-03-28 18:53:31 PDT
Comment on attachment 134470 [details]
Patch

I add explicit keyword to construct. Thank you for your review.
Comment 5 WebKit Review Bot 2012-03-28 19:57:23 PDT
Comment on attachment 134470 [details]
Patch

Clearing flags on attachment: 134470

Committed r112495: <http://trac.webkit.org/changeset/112495>
Comment 6 WebKit Review Bot 2012-03-28 19:57:29 PDT
All reviewed patches have been landed.  Closing bug.