Dynamically added link-tag disables the use of change styles dynamically

• Component: DOM
• Status: RESOLVED FIXED

[Sjoerd Mulder]

If you dynamicly add a link-tag to the head, and after this change for example the href value of this link tag. Safari constantly seems to redraw elements which are change by changing a .style. propery through testcase.

For more info see attached testcase

[Sjoerd Mulder]

Created attachment 6178 [details]
Testcase

[David Kilzer (:ddkilzer)]

Confirmed bug.  Added HasReduction keyword.

[Sjoerd Mulder]

This bug is also in Radar: <rdar://4432162>

[Alice Liu]

I tried a test case where the link tag wasn't a style sheet but just an href with the href being updated after appendChild and the flickering isn't observed.  Looks like it needs to be a style sheet, but I haven't tried other types of link tags besides that one. 

[Alice Liu]

Created attachment 7122 [details]
patch

uploading patch

[Alice Liu]

hmm, i dont know if i chose the right settings when i uploaded the patch. 

[Dave Hyatt]

Comment on attachment 7122 [details]
patch

Looks good. One minor style quibble... we leave braces off single-line if statements, so:

+                if (m_loading) {
+                    getDocument()->stylesheetLoaded();
+                }

should lose the braces.

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> r=me

Doesn't this patch need a LayoutTest, or can this not be tested automatically?

[David Kilzer (:ddkilzer)]

This patch was applied as r13371.  Updating state to RESOLVED FIXED.