Summary: | DumpRenderTree needs a way to force painting (to allow invalidation tests) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, justin.garcia, mitz | ||||
Priority: | P4 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2006-01-28 23:16:14 PST
Created attachment 7850 [details]
Patch
Comment on attachment 7850 [details]
Patch
Looks like a good start.
Comment on attachment 7850 [details]
Patch
To be more clear what I mean about that, I think eventually we want to come up with a testing approach that detects if we repaint too much as well as something that detects when we repaint too little.
(In reply to comment #3) > (From update of attachment 7850 [details] [edit]) > To be more clear what I mean about that, I think eventually we want to come up > with a testing approach that detects if we repaint too much as well as > something that detects when we repaint too little. > Something like - (void)display { NSView *webView = [frame webView]; [webView display]; [webView lockFocus]; [[NSColor blackColor] set]; NSRectFill([webView frame]); [webView unlockFocus]; readFromWindow = YES; } Will let you see exactly what was repainted (except if it was black). (In reply to comment #4) > [[NSColor blackColor] set]; or perhaps better yet, [[[NSColor blackColor] colorWithAlphaComponent:0.5] set]; |