Patch: give internal functions names (KJS merge)

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Maks Orlovich]

The attached is a preliminary patch to give builtin functions names, and have 
them print out in the way mozilla and KJS testsuites expect (mostly --- some 
mozilla testcases has a requirement on body indenting, but this fixes a 
couple). I'll probably rediff it against actual JSC later on. 
 
This basically does: 
-Move keeping track of name into InternalFunctionImp 
-Set the name when grabbing functions from hashtable 
-Set the name of manual managed properties by hand 
-Use the name when printing internal functions 
 
Based on the work done by David Faure.

[Maks Orlovich]

Created attachment 5345 [details]
patch (sorta preliminary)

[Maciej Stachowiak]

Created attachment 6635 [details]
improved patch that applies to trunk and does more cleanup

[Darin Adler]

Comment on attachment 6635 [details]
improved patch that applies to trunk and does more cleanup

Why does object_object.h now have to include function.h?

Why does kjs_binding.h now have to include function_object.h and internal.h?

r=me anyway

[Geoffrey Garen]

Comment on attachment 6635 [details]
improved patch that applies to trunk and does more cleanup

Maciej and I talked about some changes on IRC, which I pre-emptively r+

[Maciej Stachowiak]

> Why does object_object.h now have to include function.h?

No reason - fixed.

> Why does kjs_binding.h now have to include function_object.h and internal.h?

No reason any more. Removed.

[Darin Adler]

Maciej landed this last night.