Bug 6101

Summary: Leaks in XSLTProcessorImpl due to early exit in failure case
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: XMLAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Proposed patch
eric: review-
Better fix mjs: review+

Description Eric Seidel (no email) 2005-12-15 13:33:50 PST 
Leaks in XSLTProcessorImpl due to early-exit in failure case

After adding two XSLT processor failure cases to the layout tests last week it's now possible to see a leak 
caused in that code path.  The attached patch closes the leak.
Comment 1 Eric Seidel (no email) 2005-12-15 13:35:09 PST 
Created attachment 5099 [details]
Proposed patch
Comment 2 Darin Adler 2005-12-15 21:53:23 PST 
Comment on attachment 5099 [details]
Proposed patch

If the sourceDoc comes back 0, should we be returning true or false? This code
returns true. Otherwise, looks fine. I guess I'll say review+.
Comment 3 Eric Seidel (no email) 2005-12-15 22:48:07 PST 
Comment on attachment 5099 [details]
Proposed patch

Bah, my bad.  Yeah, it's supposed to return false.  I'll init success to false
instead when landing.
Comment 4 Eric Seidel (no email) 2005-12-19 14:12:54 PST 
Comment on attachment 5099 [details]
Proposed patch

This is wrong.	I have a new patch I'll post.
Comment 5 Eric Seidel (no email) 2005-12-29 20:21:54 PST 
Created attachment 5367 [details]
Better fix