Bug 5127

Summary:

REGRESSION: problems making selection with left edge at right edge of image

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Layout and Rendering

Assignee:

Justin Garcia <justin.garcia>

Status:

VERIFIED FIXED

Severity:

Major

CC:

alice.barraclough, darin, sullivan

Priority:

Keywords:

HasReduction, InRadar

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
test document	none
patch + layout tests	darin: review+

Description Alexey Proskuryakov 2005-09-25 00:55:22 PDT

Steps to reproduce:
1) Open the attached document in Blot
2) Position the caret at the end of text
3) Press Shift+Left Arrow three times

Resuls: Not only the three rightmost letters, but also the image gets selected. After pressing Shift+Left 
Arrow for the fourth time, the visible selection doesn't change

Regression: works fine with MacOS X 10.4.2/Safari 2.0.1, broken in ToT.

Comment 1 Alexey Proskuryakov 2005-09-25 00:55:55 PDT

Created attachment 4035 [details]
test document

Comment 2 Alexey Proskuryakov 2005-09-26 03:26:49 PDT

This can also be reproduced in Safari: just open the test case and drag-select from right to left. When only 
the three letters "def" should be selected, the image also gets selected.

Comment 3 Darin Adler 2005-10-09 20:08:22 PDT

I just tried, and I cannot reproduce this in my TOT build of Safari.

Comment 4 Darin Adler 2005-10-10 08:05:32 PDT

My mistake, I can reproduce this.

Comment 5 John Sullivan 2006-01-09 10:30:29 PST

Note that bug 6451 is probably the same issue.

Comment 6 Alice Liu 2006-01-10 10:20:33 PST

also see <rdar://problem/4402375>

Comment 7 Alice Liu 2006-01-10 14:37:42 PST

*** Bug 6451 has been marked as a duplicate of this bug. ***

Comment 8 Justin Garcia 2006-01-15 23:30:53 PST

Created attachment 5713 [details]
patch + layout tests

This is a bug in the painting code.  It seems like it's always existed, but
some change(s) in the last 6-8 months caused more selections to start/end on
replaced elements.  Here's a fix and 3 layout tests.  Also fixes: 
<rdar://problem/4364427> triple-click includes first item on next line
(www.apple.com, but I think I've seen it elsewhere)

Comment 9 Darin Adler 2006-01-15 23:33:22 PST

Comment on attachment 5713 [details]
patch + layout tests

Looks great. r=me

Comment 10 Justin Garcia 2006-01-16 12:23:06 PST

fixed