| Summary: | CSS2: Table cell coalescing in CSS broken | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | Tables | Assignee: | Beth Dakin <bdakin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, ian, zwarich | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 412 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Apple Bug: rdar://3299883/ Created attachment 5331 [details]
test case as attachement
CC'ing beth as this is in her area of expertise. After looking into the bug I cannot seem to locate the logic for testing adjacent cells. It does not occur in all the Rendering files and my next guess was the CSSParser, which also does not appear to have the logic. Also the use of setStyle only occurs once for TABLE_CELL, and that also does not appear to contain the logic. Any clues? Hi Bradley, (In reply to comment #4) > After looking into the bug I cannot seem to locate the logic for testing > adjacent cells. It does not occur in all the Rendering files and my next guess > was the CSSParser, which also does not appear to have the logic. Also the use > of setStyle only occurs once for TABLE_CELL, and that also does not appear to > contain the logic. Any clues? I noticed that the render tree dumps are different if you position the non table cell div first or last. In the last case two RenderTableCell's are created, the first case just one. It may be worth debugging on what basis and where these RenderTableCell's are created, maybe by stepping through the code or adding printf statements. Cheers, Rob. Created attachment 29644 [details]
Patch to add test
The bug is now fixed, but we should add this as a test.
|
<html> <head> <style> .entries { display: table-cell; } .sidebar { display: table-cell; } </style> </head> <body> <div class="nav"></div> <div class="entries">One</div> <div class="sidebar">Two</div> </body> </html> "One" and "Two" should be in the same table, so they should be in a row together. Instead they end up in separate tables all because of the presence of the extra "nav" div.