Summary: | CSS downloads all background images related to element, instead of just final rule | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lee Powell <powell.lee> | ||||||
Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andyhume, hyatt, luying.pan, mathias, rik, rniwa, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac (Intel) | ||||||||
OS: | OS X 10.5 | ||||||||
URL: | http://www.leepowell.net/webkit/ | ||||||||
Attachments: |
|
Description
Lee Powell
2009-02-27 04:19:22 PST
*** Bug 31630 has been marked as a duplicate of this bug. *** No, this still happens if the two images are referred to by different rule blocks. Created attachment 65526 [details]
Mostly complete patch
This patch works pretty well, but breaks one test: fast/css-generated-content/after-order.html
Created attachment 65622 [details]
Patch
Attachment 65622 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6725: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 65622 [details]
Patch
r=me
http://trac.webkit.org/changeset/66141 seems to have caused fast/forms/select-style.html to fail on mac: @@ -56,10 +56,10 @@ RenderText {#text} at (0,160) size 498x18 text run at (0,160) width 498: "This tests that background is white if only background-image:none is specified." RenderBR {BR} at (498,174) size 0x0 - RenderMenuList {SELECT} at (2,180) size 51x18 [bgcolor=#FFFFFF] - RenderBlock (anonymous) at (0,0) size 51x18 - RenderText at (8,2) size 20x13 - text run at (8,2) width 20: "test" + RenderMenuList {SELECT} at (2,180) size 51x18 [bgcolor=#FFFFFF] [border: (1px solid #000000)] + RenderBlock (anonymous) at (1,1) size 49x16 + RenderText at (8,1) size 20x13 + text run at (8,1) width 20: "test" RenderText {#text} at (55,179) size 4x18 text run at (55,179) width 4: " " RenderBR {BR} at (59,193) size 0x0 I filed bug 44737 to investigate the test breakage. *** Bug 52847 has been marked as a duplicate of this bug. *** |