Summary: | Regression: Shadow offsets seem to have changed in 10.5.3 in canvas | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Francisco Tolmasky <tolmasky> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz, mrowe | ||||
Priority: | P1 | Keywords: | HasReduction, InRadar, Regression | ||||
Version: | 525.x (Safari 3.1) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Francisco Tolmasky
2008-05-31 01:43:09 PDT
CanvasRenderingContext2D::applyShadow() needs to have the same extraShadowOffset logic GraphicsContext::setPlatformShadow() has in GraphicsContextCG.cpp to guarantee consistent results. I have a patch but I cannot generate test results because DRT crashes on every test. Created attachment 21452 [details]
Account for changes in CoreGraphics shadow behavior; fix recent Y-axis-direction regression
The test covers both fixes.
Does SVG have some form of shadows that may require a similar fix? Comment on attachment 21452 [details]
Account for changes in CoreGraphics shadow behavior; fix recent Y-axis-direction regression
r=me
Fixed in <http://trac.webkit.org/changeset/34287>. (In reply to comment #5) > Does SVG have some form of shadows that may require a similar fix? No, but looking for calls to CGContextSetShadow* I just realized that canvas has many more which may need to be patched as well. Additional related fixes landed in <http://trac.webkit.org/changeset/34317>. |