Summary: | Acid3 *-of-type test fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | CSS | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hyatt | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2008-02-09 01:36:56 PST
The bug is with the parseNth function. It incorrectly treats negative coefficients of n as positive. a = nth.substring(0, n).toInt(); The above is the correction. Instead of 1, n-1 it was supposed to be 0, n. I'll get a patch up once I've landed my other changes to CSSStyleSelector.cpp. There is more to this. Even fixing the coefficient to be properly parsed as negative, the matchNth function is also buggy. Created attachment 19024 [details]
Patch to fix the problem.
I was wrong. matchNth is fine. :) Comment on attachment 19024 [details]
Patch to fix the problem.
Could have just added a "-" there...
r=me
|