Bug 17226

Summary: Patch to correct Windows(Cairo) build of image-decoders
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch adding #include "config.h" aroben: review+

Description Brent Fulgham 2008-02-08 13:48:31 PST
The GIF and PNG image decoders do not include the "config.h" file, which causes various syntax errors such as:

"IFImageDecoder.cpp
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2544: expected ')' for operator '()'
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before 'string'
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2433: '()' : 'inline' not permitted on data declarations
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2059: syntax error : ')'
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before '{'
c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2447: '{' : missing function header (old-style formal list?)"
Comment 1 Brent Fulgham 2008-02-08 13:49:07 PST
Created attachment 19008 [details]
Patch adding #include "config.h"
Comment 2 Adam Roben (:aroben) 2008-02-08 13:50:04 PST
Comment on attachment 19008 [details]
Patch adding #include "config.h"

r=me
Comment 3 Mark Rowe (bdash) 2008-02-08 22:48:19 PST
Landed in r30107.