Summary: | [curl] when using winsock, downloadTimerCallback bails | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ollivier <kevino> | ||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | Curl, Wx | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Kevin Ollivier
2008-02-04 14:44:29 PST
Created attachment 18919 [details]
On Win, don't call select unless we have a valid file descriptor
Comment on attachment 18919 [details]
On Win, don't call select unless we have a valid file descriptor
That doesn't look right as it makes it possible for rc to be tested before being initialized. Why does it make sense to call select on non-Windows platforms when there are no file descriptors?
Created attachment 18978 [details]
Don't call select when there are no valid file descriptors on any platform
Good point, I did some more testing and not calling select() seems to work fine on Unix platforms too, so I've taken out the #if PLATFORM(WIN_OS) and I've also initialized rc to 0 so that it won't be used uninitialized.
Comment on attachment 18978 [details]
Don't call select when there are no valid file descriptors on any platform
Looks fine to me.
|