Bug 16329

Summary: [GTK] Two small cleanups
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
Patch
none
Cleanup alp: review+

Description Xan Lopez 2007-12-06 08:23:58 PST 
Rename m_webPage to m_webView in ChromeClient and chain to parent class in WebKitWebView to activate bindings.
Comment 1 Xan Lopez 2007-12-06 08:25:12 PST 
Created attachment 17749 [details]
Patch
Comment 2 Xan Lopez 2007-12-06 08:29:24 PST 
+    return GTK_WIDGET_CLASS(webkit_web_view_parent_class)->key_press_event (widget, event);

Extra space, blah :)
Comment 3 Xan Lopez 2007-12-06 11:55:45 PST 
Created attachment 17753 [details]
Cleanup
Comment 4 Alp Toker 2007-12-06 12:08:31 PST 
Comment on attachment 17753 [details]
Cleanup

Good, apart from a whitespace tweak (not your fault, it was that way before the change) and chaining up key_release to key_press (will fix up before landing).
Comment 5 Alp Toker 2007-12-10 13:09:39 PST 
Landed in r28490.