Bug 15169

Summary: Freeze on Google maps using the "Dig a hole" tool
Product: WebKit Reporter: Alex Stapleton <alex.stapleton>
Component: CSSAssignee: mitz
Status: RESOLVED FIXED    
Severity: Major CC: mitz, mrowe
Priority: P1 Keywords: InRadar
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
URL: http://maps.google.com
Attachments:
Description Flags
Sample of Safari during a freeze
none
Shark profile of Safari during hang
none
Fix hang on accessing the empty string property of a CSSStyleDeclaration darin: review+

Description Alex Stapleton 2007-09-10 03:24:21 PDT
Under the My Maps tab on google maps there is a tool called "Dig a hole through the earth", checking the box to enable this function causes WebKit to freeze for about 30 seconds.
Comment 1 Alex Stapleton 2007-09-10 03:24:55 PDT
Created attachment 16242 [details]
Sample of Safari during a freeze
Comment 2 David Kilzer (:ddkilzer) 2007-09-10 04:35:21 PDT
Confirmed with a local debug build of WebKit r25458 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218).  (It hangs a LOT longer on my poor PB G4!)

Note that the "Dig a hole through the Earth" feature must be added to the "My Maps" section.  It's a third-party item "Created by others".  Click the "Browser the directory" link to find and add it.
Comment 3 David Kilzer (:ddkilzer) 2007-09-10 04:38:53 PDT
Created attachment 16243 [details]
Shark profile of Safari during hang

This is a shark profile of Safari while it was hanging.  Looks like most of the time was spent in WebCore::DeprecatedString::at(unsigned) const, which is suggested by the sample in Attachment #16242 [details] as well.
Comment 4 mitz 2007-09-12 12:23:33 PDT
I have a reduction and a possible fix.
Comment 5 Mark Rowe (bdash) 2007-09-12 12:29:24 PDT
<rdar://problem/5477414>
Comment 6 mitz 2007-09-12 12:58:27 PDT
Created attachment 16268 [details]
Fix hang on accessing the empty string property of a CSSStyleDeclaration

Includes regression test.
Comment 7 Darin Adler 2007-09-12 13:01:28 PDT
Comment on attachment 16268 [details]
Fix hang on accessing the empty string property of a CSSStyleDeclaration

r=me
Comment 8 Sam Weinig 2007-09-18 11:42:04 PDT
Landed in r25619.