Summary: | REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | adele | ||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||
Version: | 523.x (Safari 3) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Attachments: |
|
Description
mitz
2007-05-18 07:42:23 PDT
Created attachment 14607 [details]
Test case
Created attachment 14748 [details]
Natural directionality patch
This is a patch that works as far as I can tell, but I think that both the left alignment and the "natural" directionality are very Mac-specific quirks that have to do with the Mac popup implementation, so it doesn't feel right to do them in cross-platform code. Those style adjustments are really something that the popup dictates, so it might make sense to do them in a PopupMenu static method (since you don't want to create a popup just for that) or a RenderTheme method.
Or you could do this in cross-platform code but have a PopupMenu method that asks whether or not you should do it. Created attachment 14770 [details]
Natural directionality patch
Comment on attachment 14770 [details]
Natural directionality patch
I think we should refactor the loop that figures out the TextDirection of a run of text into a helper function.
r=me
Created attachment 14771 [details]
Updated patch
Factored out the loop.
Comment on attachment 14771 [details]
Updated patch
+TextDirection textDirectionForParagraph(StringImpl* paragraph)
Should be marked "static" so it gets internal linkage.
r=me
|