editing/style/fontsize-1.html fails intermittently when run multiple times on Intel, generates incorrect DOM

• Component: HTML Editing
• Status: RESOLVED FIXED

On a debug build of TOT running on an Intel machine, "run-webkit-tests editing/style/fontsize-1.html editing/style/fontsize-1.html editing/style/fontsize-1.html editing/style/fontsize-1.html editing/style/fontsize-1.html" fails one or more instances of the test sometimes. Even when the test passes, when opened in Safari one can see that the DOM tree includes FONT elements with size="1" (or in the failing case, one of them has size="7"; neither size is correct, and the actual size is determined by an inline style attribute on a child SPAN).

Patch forthcoming.

Created attachment 13914 [details]
Don't generate 'size' attribute for relative font sizes, and ASSERT on wildly illegal conversions

[Darin Adler]

Comment on attachment 13914 [details]
Don't generate 'size' attribute for relative font sizes, and ASSERT on wildly illegal conversions

I'd prefer not to have ad-hoc comparisons of the unit type with values. All the < PX, > PC, <= CSS_DIMENSION is quite unclear and should be done with helper inline functions instead.

But for this fix, r=me

[Mark Rowe (bdash)]

Landed in r20678.