line-height in font shorthand does not override a previously stated line-height property

• Component: CSS
• Status: RESOLVED FIXED

[Dan Richman]

If you set a line-height value for a block of text, and then later on in your style sheet you try to declare a font shorthand property that contains a line-height value, it will not override the previously stated line-height property.

A workaround is to simple re-declare a regular line-height property in addition to the font shorthand property.

Please compare the testcase in other browsers to see proper implementation.

[Dan Richman]

Created attachment 13787 [details]
Testcase

[Rob Buis]

Created attachment 14641 [details]
First  attempt

This should do it. It can be cleaned up a bit more I think, but I hope the approach is right.
Cheers,

Rob.

[Dave Hyatt]

Comment on attachment 14641 [details]
First  attempt

Per conversation on IRC, I suggested just always making line-height be mapped in as one of the first properties like font.

However instead of going into the RenderStyle in the switch statement it would just be cached as a member variable on the style selector.

After the style has been determined (e.g., around the time adjustRenderStyle is going to get called), that line height value (if it exists) should be mapped in for real.

[Rob Buis]

Created attachment 14650 [details]
Different approach

As discussed with Hyatt on IRC, this is probably a better approach.
Cheers,

Rob.

[Dave Hyatt]

Comment on attachment 14650 [details]
Different approach

r=me

[David Kilzer (:ddkilzer)]

Confirmed by existence of patches.

[Sam Weinig]

Landed in r21667.