Bug 13108

Summary: REGRESSION(r20269): frameborder attribute ignored
Product: WebKit Reporter: Ain Tohvri <ain>
Component: FramesAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P1 Keywords: Regression
Version: 523.x (Safari 3)   
Hardware: Mac (Intel)   
OS: OS X 10.4   
URL: http://www.seb.ee/index/1301
Attachments:
Description Flags
frameborder set to 0 still displays
none
https://www.google.com/adsense/login3
none
Patch that fixes numerous bugs with frame borders and resizing ggaren: review+

Description Ain Tohvri 2007-03-18 10:40:24 PDT
Sites that have frames with frameborder='0' still render frames
Comment 1 Ain Tohvri 2007-03-18 10:42:00 PDT
Created attachment 13692 [details]
frameborder set to 0 still displays

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
<html>
<head>
	<title>SEB Eesti Ühispank</title>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
	<meta name="robots" content="all">
	<meta name="robots" content="noarchive">
	<meta name="robots" content="index, follow">
	<meta name="rating" content="general">
	<meta name="title" content="SEB Eesti Ühispank">
	<meta name="description" content="">
	<meta name="keywords" content="">
</head>
<frameset rows="84,*">
	<frame src="/show/topmenu/0101" name="header" frameborder="0" noresize="noresize" scrolling="no" marginheight="0" marginwidth="10" />
	
	<frameset cols="180,*">
		<frame src="/show/menu/0101" name="lmenu" frameborder="0" marginheight="0" marginwidth="10" noresize scrolling="no" />
		<frame src="/page/0101" name="main" frameborder="0" marginheight="0" marginwidth="0" scrolling="auto" noresize />
	</frameset>
</frameset>
</html>
Comment 2 Geoffrey Garen 2007-03-18 11:01:19 PDT
This is a recent (past day or two) regression in TOT. Marking P1.
Comment 3 Dave Hyatt 2007-03-18 13:11:03 PDT
I see what I messed up. This is easy to fix.  The space is still supposed to be there.. the borders just don't render.
Comment 4 Ain Tohvri 2007-03-18 13:18:30 PDT
(In reply to comment #3)
> I see what I messed up. This is easy to fix.  The space is still supposed to be
> there.. the borders just don't render.
> 

Good news. Just to note that it affects IFRAME as well.
Comment 5 Dave Hyatt 2007-03-18 14:20:53 PDT
It  does?  iframe should be fixed.
Comment 6 Dave Hyatt 2007-03-18 14:21:10 PDT
Could you attach an iframe example?
Comment 7 Ain Tohvri 2007-03-18 14:39:34 PDT
Created attachment 13694 [details]
https://www.google.com/adsense/login3

Google AdSense login page uses IFRAME that renders frames despite the 0 attribute
Comment 8 Dave Hyatt 2007-03-18 18:04:34 PDT
Created attachment 13700 [details]
Patch that fixes numerous bugs with frame borders and resizing
Comment 9 Geoffrey Garen 2007-03-18 18:56:45 PDT
Comment on attachment 13700 [details]
Patch that fixes numerous bugs with frame borders and resizing

please add changelog + tests before landing.
Comment 10 Dave Hyatt 2007-03-18 22:08:31 PDT
Fixed.