| Summary: | Fix and import 4XPath test_numeric_expr.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | XML | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P1 | ||||||
| Version: | 523.x (Safari 3) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 12953 | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2007-03-06 10:54:55 PST
Created attachment 13491 [details]
proposed fix
Not converting to DeprecatedString in Value::toNumber() helps because DeprecatedString::ascii() has an apparent bug: all characters above 0xFF are converted to \0, so toDouble("\u2022abc") returns 0 instead of failure.
I thought about fixing this globally, but the problem is deep inside DeprecatedStringData:makeAscii(), and changing it now seems too dangerous to me.
Comment on attachment 13491 [details]
proposed fix
This looks good. I am not sure whether putting a comment in DeprecatedString is worth it (since it is deprecated), but perhaps noting the bug in source might be a good idea.
r=me!
Committed revision 20008. |