Summary: | REGRESSION: Comments fields on ircimages not showing up in nightly | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jarvis Badgley <chiper> |
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, KwhiteRight |
Priority: | P1 | Keywords: | InRadar, NeedsReduction, Regression |
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://ircimages.com |
Description
Jarvis Badgley
2007-02-10 21:33:24 PST
Works with shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127). Does not work with a local debug build of WebKit r19554 with the same software. The comments that aren't showing up are <iframe> elements. This site loads its content in a quite interesting way: 1) HTML markup is retrieved via XMLHttpRequest; 2) then it is assigned via innerHTML to a temporary display:none div; 3) the div's innerHTML is taken back; 4) the div is cleared; 5) the content is finally written in place - again, via innerHTML. This is repeated for several parts of the page, but the main part (with images and comment subframes) is all loaded in a single request. So subframe loading is initiated in step 2, to be immediately canceled in step 4. This confuses WebKit page loading machinery. this.getBrowserHTML = function (html) { tmpXajax = this.$(this.workId); if (!tmpXajax) { tmpXajax = document.createElement("div"); tmpXajax.setAttribute("id", this.workId); tmpXajax.style.display = "none"; tmpXajax.style.visibility = "hidden"; document.body.appendChild(tmpXajax); } tmpXajax.innerHTML = html; var browserHTML = tmpXajax.innerHTML; tmpXajax.innerHTML = ""; return browserHTML; }; Committed revision 24396. |