Summary: | REGRESSION (r12358): Text in display: table unselectable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mitz | ||||||
Priority: | P1 | Keywords: | HasReduction, Regression | ||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Matt Lilek
2006-10-12 19:47:02 PDT
Created attachment 11060 [details]
Testcase
Looks like a regression from <http://trac.webkit.org/projects/webkit/changeset/12358>. I am preparing a patch. Created attachment 12540 [details]
Patch
No editing test regressions.
Comment on attachment 12540 [details]
Patch
Looks good. The way Hyatt had me fix something like this in another similar case was to ask the renderer "isText() && !isBR()" instead of doing the checking on the DOM tree side.
I think we should have a RenderObject call that returns style for other renderers and 0 for text renderers that are not <br> elements. Or a boolean check on RenderObject like isRealText() which is isText() && !isBR().
r=me
|